Skip to content

fix: coerce is_telemetry_enabled form values on instance admin signup #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranav-afk wants to merge 1 commit into
base: preview
Choose a base branch
from
+12 −1
Open

fix: coerce is_telemetry_enabled form values on instance admin signup #9415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apps/api/plane/license/api/views/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,18 @@ def post(self, request):
first_name = request.POST.get("first_name", False)
last_name = request.POST.get("last_name", "")
company_name = request.POST.get("company_name", "")
is_telemetry_enabled = request.POST.get("is_telemetry_enabled", True)
# Form posts may send "true"/"false" strings; coerce to a real bool so
# assignment to Instance.is_telemetry_enabled does not 500 on save.
is_telemetry_enabled_raw = request.POST.get("is_telemetry_enabled", True)
if isinstance(is_telemetry_enabled_raw, bool):
is_telemetry_enabled = is_telemetry_enabled_raw
else:
is_telemetry_enabled = str(is_telemetry_enabled_raw).strip().lower() in {
"1",
"true",
"yes",
"on",
}

# return error if the email and password is not present
if not email or not password or not first_name:
Expand Down