-
Notifications
You must be signed in to change notification settings - Fork 11
Cursor movement and testing revamp #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to not affect the highlight offset
Sploder12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should tests be added for the snprintf bugs you caught?
Sploder12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! No major changes needed, mostly formatting and code reuse. My biggest suggestion is using newlines to separate code a bit more since everything is a bit squished without them.
… to save progress
…extract more but I can't quite figure out how
Sploder12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Color seems to not work on Windows for tests though
…s lack of ansi color support
Sploder12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This pull request adds cursor movement via the arrow keys, character deletion via the
deleteandbackspacekeys, highlighting by moving the cursor while holding shift. Using the arrow keys while highlighting also changes the behavior slightly, such as the deletion keys also deleting the highlighted characters, or the . There are also some fixes totest.pyandvsnprintfinstdio.cand a non-breaking revamp to the test assertion macro to allow for the printing of values for the purpose of debugging.Issue #(N/A, no issue was made for this)Type of change
^ Added cursor movement and highlighting, as well as more powerful testing utilities
^ Fixed
vsnprintf's%sand%iformat specifiersTesting
Please describe tests that you ran to verify your changes. Provide instructions so that we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
test_keyboard.cwith the help of @Alex105178, who made the initial framework for testingChecklist: