Support contractPackageHash for CsprTrade URLs#43
Merged
Conversation
- Updated common.ts to include `contractPackageHash` in `getMarketDataProviderUrl` for token-specific URLs - Enhanced DTOs to pass `contractPackageHash` where applicable - Added tests to validate behavior with and without `contractPackageHash`
Comp0te
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for
contractPackageHashin CsprTrade URLs. UpdatedgetMarketDataProviderUrlin common.ts to includecontractPackageHashfor token-specific URL generation. Enhanced DTOs to incorporatecontractPackageHashwhere appropriate and added tests to verify behavior.Motivation
This change enables token-specific URL generation for CsprTrade by supporting
contractPackageHash. This improves the flexibility of token operations.Related issues
Notes for reviewers
Please check the added tests, especially the scenarios with and without
contractPackageHash. Ensure no unintended side effects are introduced.