Conversation
|
What needs to be done to progress on that request? |
|
Sorry, I didn't notice the test failures were timeouts due to GitHub infrastructure issues, not actual errors in the submission. |
| - id: evyy1wbhi4t7uftn | ||
| model: "eCosy 2024" | ||
| entities: | ||
| - entity: climate |
There was a problem hiding this comment.
There is no point to use a climate entity here, as there is no temperature and current_temperature nor hvac_mode (though the below switch should probably be hvac_mode).
Is there really only 2 dps for this device?
| @@ -0,0 +1,28 @@ | |||
| name: eCosy | |||
There was a problem hiding this comment.
Top level name should be generic, not a specific model name, as other devices may also match this config.
The device type should also be at the end of the filename to assist users to understand what they are selecting.
(konyks_ecosy2024_heater.yaml for example)
| name: eCosy | ||
| products: | ||
| - id: evyy1wbhi4t7uftn | ||
| model: "eCosy 2024" |
There was a problem hiding this comment.
manufacturer: Konyks seems to be missing here.
| - dps_val: eco | ||
| value: "Eco" | ||
| - dps_val: cold | ||
| value: "Hors gel" |
There was a problem hiding this comment.
Is it anti-frost?
In general you should use presets that are defined in
https://github.com/home-assistant/core/blob/dev/homeassistant/components/climate/strings.json#L151
or use a translation_key for extended presets from
https://github.com/make-all/tuya-local/blob/main/custom_components/tuya_local/translations/fr.json#L164
Devices are wire pilot control for heaters, quite French specific.
The DP mapping is quite strange and I spent some time debugging it. It's been tested live at home with 5 eCosy running.