Skip to content

feat: format Time field in forwarded messages#127

Closed
Memory2314 wants to merge 1 commit intomagisk317:devfrom
Memory2314:feat/forward-time-format
Closed

feat: format Time field in forwarded messages#127
Memory2314 wants to merge 1 commit intomagisk317:devfrom
Memory2314:feat/forward-time-format

Conversation

@Memory2314
Copy link

@Memory2314 Memory2314 commented Feb 26, 2026

Summary by Sourcery

增强功能:

  • 在转发的消息中,将短信日期字段格式化为人类可读的 yyyy.MM.dd HH:mm:ss 格式,而不是使用原始时间戳。
Original summary in English

Summary by Sourcery

Enhancements:

  • Format the SMS date field in forwarded messages using a human-readable yyyy.MM.dd HH:mm:ss pattern instead of the raw timestamp.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 26, 2026

审阅者指南(在小型 PR 上折叠)

审阅者指南

通过引入一个可复用的日期格式化辅助函数,并将其应用到钉钉和 Telegram 的转发路径上,为被转发内容格式化短信消息的时间戳。

带日期格式化辅助函数的更新版 ForwardAction 类图

classDiagram
    class ForwardAction {
        +ForwardAction(pluginContext: Context, phoneContext: Context, smsMsg: SmsMsg)
        -formatDate(timestamp: Long): String
        forwardToDingTalk(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
        forwardToTelegram(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
    }
Loading

文件级变更

变更 详情 文件
为被转发消息中的短信时间戳引入可复用的日期格式化功能。
  • 添加 SimpleDateFormat/Date/Locale 的导入以支持时间戳格式化。
  • 实现一个私有的 formatDate(timestamp: Long) 辅助函数,使用默认 Locale 将时间戳格式化为 "yyyy.MM.dd HH:mm:ss"。
  • 在构建钉钉消息时,将直接使用 mSmsMsg.date 替换为 formatDate(mSmsMsg.date)。
  • 在构建 Telegram 消息时,将直接使用 mSmsMsg.date 替换为 formatDate(mSmsMsg.date)。
app/src/main/java/com/tianma/xsmscode/xp/hook/code/action/impl/ForwardAction.kt

技巧与命令

与 Sourcery 交互

  • 触发新的审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub issue: 通过回复某条审阅评论,要求 Sourcery 从该评论创建一个 issue。你也可以在审阅评论下回复 @sourcery-ai issue 来从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题中的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文的任意位置写上 @sourcery-ai summary,即可在你想要的位置随时生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可在任意时间(重新)生成审阅者指南。
  • 批量解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。当你已经处理完所有评论且不希望再看到它们时很有用。
  • 忽略所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审阅。特别适合想从头开始新的审阅的场景——别忘了再评论 @sourcery-ai review 来触发新一轮审阅!

自定义你的使用体验

前往你的 控制台 以:

  • 启用或禁用审阅功能,例如 Sourcery 生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Formats the SMS message timestamp for forwarded content by introducing a reusable date-formatting helper and applying it to both DingTalk and Telegram forwarding paths.

Class diagram for updated ForwardAction with date formatting helper

classDiagram
    class ForwardAction {
        +ForwardAction(pluginContext: Context, phoneContext: Context, smsMsg: SmsMsg)
        -formatDate(timestamp: Long): String
        forwardToDingTalk(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
        forwardToTelegram(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
    }
Loading

File-Level Changes

Change Details Files
Introduce reusable date formatting for SMS timestamps in forwarded messages.
  • Add SimpleDateFormat/Date/Locale imports to support timestamp formatting.
  • Implement a private formatDate(timestamp: Long) helper that formats timestamps as "yyyy.MM.dd HH:mm:ss" using the default locale.
  • Replace direct usage of mSmsMsg.date with formatDate(mSmsMsg.date) in the DingTalk message builder.
  • Replace direct usage of mSmsMsg.date with formatDate(mSmsMsg.date) in the Telegram message builder.
app/src/main/java/com/tianma/xsmscode/xp/hook/code/action/impl/ForwardAction.kt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我已经审查了你的更改,一切看起来都很棒!


Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@magisk317
Copy link
Owner

项目在重构,暂时不接受pr,感谢~

@magisk317 magisk317 closed this Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants