feat: format Time field in forwarded messages#127
Closed
Memory2314 wants to merge 1 commit intomagisk317:devfrom
Closed
feat: format Time field in forwarded messages#127Memory2314 wants to merge 1 commit intomagisk317:devfrom
Memory2314 wants to merge 1 commit intomagisk317:devfrom
Conversation
审阅者指南(在小型 PR 上折叠)审阅者指南通过引入一个可复用的日期格式化辅助函数,并将其应用到钉钉和 Telegram 的转发路径上,为被转发内容格式化短信消息的时间戳。 带日期格式化辅助函数的更新版 ForwardAction 类图classDiagram
class ForwardAction {
+ForwardAction(pluginContext: Context, phoneContext: Context, smsMsg: SmsMsg)
-formatDate(timestamp: Long): String
forwardToDingTalk(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
forwardToTelegram(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
}
文件级变更
技巧与命令与 Sourcery 交互
自定义你的使用体验前往你的 控制台 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideFormats the SMS message timestamp for forwarded content by introducing a reusable date-formatting helper and applying it to both DingTalk and Telegram forwarding paths. Class diagram for updated ForwardAction with date formatting helperclassDiagram
class ForwardAction {
+ForwardAction(pluginContext: Context, phoneContext: Context, smsMsg: SmsMsg)
-formatDate(timestamp: Long): String
forwardToDingTalk(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
forwardToTelegram(botToken: String, chatId: String, isCodeSms: Boolean, url: URL): Boolean
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - 我已经审查了你的更改,一切看起来都很棒!
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
|
项目在重构,暂时不接受pr,感谢~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
增强功能:
yyyy.MM.dd HH:mm:ss格式,而不是使用原始时间戳。Original summary in English
Summary by Sourcery
Enhancements: