Feat:pulsating button enhancement#936
Merged
Yeom-JinHo merged 15 commits intomagicuidesign:mainfrom Apr 4, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
…port all CSS color formats
d86f611 to
1c0d1a6
Compare
Yeom-JinHo
approved these changes
Apr 4, 2026
Member
Yeom-JinHo
left a comment
There was a problem hiding this comment.
@abdmjd1
Tysm for the thoughtful improvements here.
I went ahead and made a few follow-up fixes on top of your PR to address the remaining issues, and everything looks good now. I’m going to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances the existing
PulsatingButtoncomponent with automatic pulse color detection, a new animation variant, and additional props for greater customization.Changes
PulsatingButtonto remove unnecessary markupdistanceprop to control how far the pulse expands (default: "8px")variantprop with two animation styles:"pulse"and"ripple"(default: "pulse")pulseColornow accepts any valid CSS color instead of rgb numbers only"use client"directive for Next.js App Router compatibilitypulsating-button-demo-2.tsx)Motivation
Breaking Changes
pulseColorno longer defaults to"#808080".divis removed). Custom styles targeting that element will no longer work.Screenshots
Screenshots
pulsating.button.mp4