Skip to content

Feat:pulsating button enhancement#936

Merged
Yeom-JinHo merged 15 commits intomagicuidesign:mainfrom
abdmjd1:feat/pulsating-button-enhancement
Apr 4, 2026
Merged

Feat:pulsating button enhancement#936
Yeom-JinHo merged 15 commits intomagicuidesign:mainfrom
abdmjd1:feat/pulsating-button-enhancement

Conversation

@abdmjd1
Copy link
Copy Markdown
Contributor

@abdmjd1 abdmjd1 commented Apr 4, 2026

Description

Enhances the existing PulsatingButton component with automatic pulse color detection, a new animation variant, and additional props for greater customization.

Changes

  • Refactored PulsatingButton to remove unnecessary markup
  • Pulse color is now automatically derived from the button's computed background color — no longer requires manual color input
  • Added distance prop to control how far the pulse expands (default: "8px")
  • Added variant prop with two animation styles: "pulse" and "ripple" (default: "pulse")
  • pulseColor now accepts any valid CSS color instead of rgb numbers only
  • Added "use client" directive for Next.js App Router compatibility
  • Added demo file for the ripple variant (pulsating-button-demo-2.tsx)
  • Updated documentation with new props and corrected prop descriptions

Motivation

  • derive pulse color from the button's background color as a defualt
  • enhance component's customization with new animation variant and distance variant.

Breaking Changes

  • pulseColor no longer defaults to "#808080".
  • The internal DOM structure has changed (the absolutely positioned div is removed). Custom styles targeting that element will no longer work.

Screenshots

Screenshots

pulsating.button.mp4

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

Someone is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo Yeom-JinHo self-requested a review April 4, 2026 11:20
@Yeom-JinHo Yeom-JinHo force-pushed the feat/pulsating-button-enhancement branch from d86f611 to 1c0d1a6 Compare April 4, 2026 11:40
Copy link
Copy Markdown
Member

@Yeom-JinHo Yeom-JinHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdmjd1
Tysm for the thoughtful improvements here.

I went ahead and made a few follow-up fixes on top of your PR to address the remaining issues, and everything looks good now. I’m going to merge this.

@Yeom-JinHo Yeom-JinHo merged commit ad82ba6 into magicuidesign:main Apr 4, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants