Skip to content

fix: restore auth panel#15

Closed
Dodecahedr0x wants to merge 3 commits into
mainfrom
dode/fix-authenticate
Closed

fix: restore auth panel#15
Dodecahedr0x wants to merge 3 commits into
mainfrom
dode/fix-authenticate

Conversation

@Dodecahedr0x
Copy link
Copy Markdown
Contributor

@Dodecahedr0x Dodecahedr0x commented May 4, 2026

Closes #16

Summary by CodeRabbit

  • Bug Fixes
    • Fixed authentication overlay visibility in the net-worth panel. The authentication card now displays correctly when wallet connection is present but authentication is required.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pay Ready Ready Preview, Comment May 4, 2026 3:18pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@Dodecahedr0x has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 39 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5ca74b6a-5b42-43c8-ac09-9cad9d61fa5a

📥 Commits

Reviewing files that changed from the base of the PR and between 4b2370c and 33325dc.

📒 Files selected for processing (2)
  • lib/payments.ts
  • lib/spl-private-balance.ts

Walkthrough

The PR extracts a MOCK_TEE constant to a centralized module, updates dependent code to use it, and removes an early-return condition in the authentication overlay component to allow proper display of the authentication card.

Changes

Authentication Mock Consolidation and Overlay Display

Layer / File(s) Summary
Constant Extraction
lib/payments.ts
New MOCK_TEE constant exported, derived from process.env.NEXT_PUBLIC_MOCK_TEE === "true"; PAYMENTS_CLUSTER and getPaymentsExplorerTransactionUrl are reformatted without behavioral change.
Core Logic Migration
lib/spl-private-balance.ts
fetchSplChallenge and loginSplPrivate now use centralized MOCK_TEE import instead of directly accessing process.env.NEXT_PUBLIC_MOCK_TEE.
UI Component Fix
components/one/net-worth-panel.tsx
Early-return guard removed; component now renders the authentication overlay card instead of returning null when authentication is required.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: restore auth panel' directly aligns with the main change: removing a temporary early-return that hid the authentication overlay, allowing the auth panel to be displayed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dode/fix-authenticate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 58 minutes and 39 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Dodecahedr0x Dodecahedr0x marked this pull request as ready for review May 4, 2026 13:33
@Dodecahedr0x Dodecahedr0x requested a review from GabrielePicco May 4, 2026 13:33
@GabrielePicco
Copy link
Copy Markdown
Contributor

Closing as superseded by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: restore auth panel

2 participants