Skip to content

feat: debounce comments#1245

Closed
Dodecahedr0x wants to merge 3 commits into
masterfrom
dode/debounce-notif
Closed

feat: debounce comments#1245
Dodecahedr0x wants to merge 3 commits into
masterfrom
dode/debounce-notif

Conversation

@Dodecahedr0x
Copy link
Copy Markdown
Contributor

@Dodecahedr0x Dodecahedr0x commented May 25, 2026

Summary

Debounces slack notifications

Breaking Changes

  • None

Summary by CodeRabbit

  • Chores
    • Reduced Slack notification noise by introducing a configurable debounce interval for PR review submissions.
    • Aggregated multiple reviews within the debounce window into a single notification.
    • Made review messages time- and state-aware, using phrasing like "approved", "requested changes", or "commented" with correct singular/plural counts.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4767df87-5f2c-4a8f-ae7a-50c2080415b1

📥 Commits

Reviewing files that changed from the base of the PR and between dfbeaa4 and 0a5a64f.

📒 Files selected for processing (1)
  • .github/workflows/slack-notify.yml

📝 Walkthrough

Walkthrough

This PR adds a configurable debounce mechanism for Slack notifications triggered by PR review submissions. The workflow now delays notifications by 120 seconds (configurable via REVIEW_NOTIFICATION_DEBOUNCE_SECONDS), uses concurrency groups keyed by PR number and reviewer identity to cancel in-progress duplicate notifications, fetches and aggregates reviews submitted by the same reviewer within the debounce window, and constructs Slack messages with aggregated counts and state-dependent wording (including correct singular/plural handling for comments).

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dode/debounce-notif

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Dodecahedr0x Dodecahedr0x marked this pull request as ready for review May 25, 2026 22:16
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/slack-notify.yml:
- Line 102: The default debounce window is inconsistent: update the fallback in
the debounceSeconds initialization so it matches the workflow sleep duration by
using 120 instead of 90; specifically change the expression that sets
debounceSeconds (Number(process.env.REVIEW_NOTIFICATION_DEBOUNCE_SECONDS || 90))
to use 120 so REVIEW_NOTIFICATION_DEBOUNCE_SECONDS and the sleep step use the
same default aggregation window.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3a564d46-9758-4101-98a0-629181e5927d

📥 Commits

Reviewing files that changed from the base of the PR and between 2277af6 and dfbeaa4.

📒 Files selected for processing (1)
  • .github/workflows/slack-notify.yml

Comment thread .github/workflows/slack-notify.yml Outdated
Copy link
Copy Markdown
Collaborator

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, this make the CI sleep keeping the machine up an running (which is costly).
I believe we can just filter codex, code rabbit comments to reduce the noise.

We could also remove self notification for single comments, like. @x xxx submitted a commented review for PR #1171: feat: compression as not useful/relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants