Skip to content

fix: use checked_add for total_fee_requested in process_delegation_cleanup #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amathxbt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use checked_add for total_fee_requested in process_delegation_cleanup #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/processor/fast/undelegate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,11 @@ fn process_delegation_cleanup(
let commit_fee = COMMIT_FEE_LAMPORTS
.checked_mul(commit_count)
.ok_or(DlpError::Overflow)?;
let total_fee_requested = commit_fee + SESSION_FEE_LAMPORTS;
// Guard against overflow when adding the fixed session fee on top of the
// per-commit fee, which can be large for long-lived delegations.
let total_fee_requested = commit_fee
.checked_add(SESSION_FEE_LAMPORTS)
.ok_or(DlpError::Overflow)?;
let total_lamports = delegation_record_account.lamports()
+ delegation_metadata_account.lamports();
let mut fee_remaining = total_fee_requested.min(total_lamports);
Expand Down