Refactor Mux provider to use new operations generator#30
Open
plcdnl wants to merge 2 commits intomagicasaservice:mainfrom
Open
Refactor Mux provider to use new operations generator#30plcdnl wants to merge 2 commits intomagicasaservice:mainfrom
plcdnl wants to merge 2 commits intomagicasaservice:mainfrom
Conversation
Contributor
|
@plcdnl I am getting a lot of type errors, most likely due to an upstream bug: nuxt/image#1942 Once this is fixed, I'll gladly take another look! |
Author
|
Hi @robinscholz, this will be fixed in nuxt/image v2, which also includes Shopify Image CDN integration. I had updated the package locally but forgot to push the update to the repo — I’m already using the alpha release of nuxt/image v2. I’m happy to have contributed, thanks for all the work you’re doing! |
Contributor
|
In that case I’d like to wait until v2 is stable and update this package then, so to not introduce an alpha-versioned peer dependency. I'll leave this PR up until then. We’ll most likely also need to update the maas provider once v2 is stable. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completed the Mux provider implementation that was left unfinished. The provider now works correctly with Mux's image API.
Changes Made
Fixed the provider to work with Mux playback IDs as src
Implemented proper URL generation for both static thumbnails and animated content
Added automatic detection for animated content based on start/end times
Added size validation (640px limit as per Mux requirements)
Usage
The provider now generates correct URLs like:
https://image.mux.com/{playback-id}/thumbnail.webp?width=400&height=300
https://image.mux.com/{playback-id}/animated.gif?start=5&end=10&fps=15