Use only numbers from git tags when creating CFBundleShortVersionString#1384
Open
mathocosta wants to merge 2 commits intomagicalpanda:masterfrom
mathocosta:master
Open
Use only numbers from git tags when creating CFBundleShortVersionString#1384mathocosta wants to merge 2 commits intomagicalpanda:masterfrom mathocosta:master
mathocosta wants to merge 2 commits intomagicalpanda:masterfrom
mathocosta:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the company I work with we use MagicalRecord and Carthage as a dependency manager. Due to this problem, we had to fork the repository with the modification described because we used tags in git in the following format:
beta/202010111458and when compiling MagicalRecord, this text was like CFBundleShortVersionString and resulted in the issue"This bundle is The value for key CFBundleShortVersionString 'beta/202010111458' in the Info.plist file must be a period-separated list of at most three non-negative integers.".So this modification in the
set_version_information.shscript solves the problem and I think it might be interesting for other projects that use lib, as described in the issue #1259.Anyway, this PR is one of my contributions for Hacktoberfest 2020, so even if it's not merged, I would love it if a maintainer could add the
hacktoberfest-acceptedtag in PR if it is an interesting contribution. 😄