Introduce optional filter capabilities when restoring default values#24
Open
rutgerrademaker wants to merge 9 commits intomagento-hackathon:mainfrom
Open
Introduce optional filter capabilities when restoring default values#24rutgerrademaker wants to merge 9 commits intomagento-hackathon:mainfrom
rutgerrademaker wants to merge 9 commits intomagento-hackathon:mainfrom
Conversation
Rename remove to restore to be consistent with task name Introduce exceptions instead trying to solve this with a null value
Contributor
|
Cool!! |
…ed correctly (when multiple stores are used)
Author
|
@peterjaap We're not done testing, but from a coding perspective I think I'm done by now |
sprankhub
reviewed
Feb 26, 2024
Member
sprankhub
left a comment
sprankhub
left a comment
There was a problem hiding this comment.
Nice one, thanks, @rutgerrademaker! I didn't test it just checked the code.
…be store code instead
…eting null values use the attibute and store filters
sprankhub
approved these changes
Mar 21, 2024
Member
sprankhub
left a comment
sprankhub
left a comment
There was a problem hiding this comment.
@rutgerrademaker, happy to merge this when you are happy with your testing :)
Contributor
|
@rutgerrademaker due to refactoring of hard-coded queries to Magento's query builder, there are merge conflicts. If you want to have this merged, could you maybe solve the merge conflicts? Otherwise I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is that we needed
N.B. I'm still in the phase of testing this, for now I'm only working with products, but I don't see why it would not also work for categories.
Just wanted to get this out there before the weekend started