Skip to content

Update agents and skills with broad support for Claude, Codex, and GitHub Copilot#1786

Open
SamErde wants to merge 6 commits into
mainfrom
samerde/review-github-setup
Open

Update agents and skills with broad support for Claude, Codex, and GitHub Copilot#1786
SamErde wants to merge 6 commits into
mainfrom
samerde/review-github-setup

Conversation

@SamErde
Copy link
Copy Markdown
Contributor

@SamErde SamErde commented May 18, 2026

📑 Description

This pull request introduces and synchronizes three Maester workflow agents—maester-issue-manager, maester-test-planner, and maester-test-expert—across Codex, Claude, and GitHub agent/skill configuration files. The changes standardize agent descriptions, responsibilities, and constraints, clarify the Maester test ID reservation workflow, and ensure all documentation points to a single source of truth for Maester test authoring.

Maester Agent Definitions and Synchronization

  • Added and aligned agent configuration files for maester-issue-manager, maester-test-planner, and maester-test-expert across .codex/agents/, .claude/agents/, and .github/agents/skills/ directories, ensuring consistent descriptions, responsibilities, and constraints. [1] [2] [3] [4] [5] [6] [7] [8]

Maester Test ID Reservation Workflow

Agent Responsibilities and Guardrails

  • Updated agent responsibilities to emphasize clear issue management, sequenced test planning, and adherence to Maester conventions and validation checklists, with explicit constraints on source code modification and issue creation. [1] [2] [3] [4] [5]

Documentation and Source of Truth

  • Established .github/skills/maester-test-expert/SKILL.md as the canonical reference for Maester check authoring, with pointer files and sync notes in all agent/skill definitions to ensure consistency. [1] [2]

Tooling and Sync Notes

  • Added explicit SYNC NOTE comments to all agent files to guide future updates and maintain parity between Claude, Copilot, and Codex toolchains. [1] [2] [3] [4] [5] [6]

These updates ensure a standardized, maintainable, and well-documented workflow for Maester test planning, implementation, and issue tracking.

SamErde added 4 commits May 18, 2026 11:17
…kill documentation: maester issue manager, test expert, planner agents.

- Created `maester-issue-manager.md` for managing GitHub issues related to Maester test tracking.
- Added `maester-test-expert.md` to provide guidance on writing and validating security checks for Microsoft 365 tenants.
- Introduced `maester-test-planner.md` to assist in planning Maester test work before implementation.
- Established `SKILL.md` as the canonical skill content for the Maester test expert, detailing authoring conventions and validation checklists.
@SamErde SamErde self-assigned this May 18, 2026
Copilot AI review requested due to automatic review settings May 18, 2026 15:23
@SamErde SamErde requested a review from a team as a code owner May 18, 2026 15:23
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 18, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying maester with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d6e7a9
Status: ✅  Deploy successful!
Preview URL: https://48bc425e.maester.pages.dev
Branch Preview URL: https://samerde-review-github-setup.maester.pages.dev

View logs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Maester workflow agent definitions (issue manager, test planner, test expert) across Codex/Claude/GitHub configuration formats, and establishes a single canonical source of truth for Maester check authoring guidance.

Changes:

  • Refines .gitignore to ignore most Claude Code artifacts while explicitly re-including committed agent/skill directories.
  • Adds/aligns Codex and Claude agent definitions for maester-issue-manager, maester-test-planner, and maester-test-expert.
  • Updates GitHub agent definitions (planner/issue-manager) with sync notes and a clearer MT ID reservation workflow tied to issue #697.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.gitignore Switches from blanket .claude/** ignore to “ignore by default, re-include committed subtrees” patterns.
.github/agents/maester-test-planner.agent.md Expands planner description/responsibilities and adds sync note linking to Claude twin.
.github/agents/maester-issue-manager.agent.md Expands issue manager workflow (including MT ID reservation steps) and adds sync note linking to Claude twin.
.codex/agents/maester-test-planner.toml Adds Codex agent config for the planner with synced responsibilities/constraints.
.codex/agents/maester-test-expert.toml Adds Codex agent config pointing to the canonical .github/skills/.../SKILL.md.
.codex/agents/maester-issue-manager.toml Adds Codex agent config for issue management, including the MT ID reservation workflow.
.claude/skills/maester-test-expert/SKILL.md Adds a Claude skill “pointer” file directing to the canonical GitHub skill doc.
.claude/agents/maester-test-planner.md Adds Claude planner agent file intended to stay in sync with the GitHub agent body.
.claude/agents/maester-test-expert.md Replaces the large embedded skill content with a pointer to the canonical GitHub skill doc.
.claude/agents/maester-issue-manager.md Adds Claude issue manager agent file intended to stay in sync with the GitHub agent body.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/agents/maester-issue-manager.agent.md Outdated
@SamErde SamErde changed the title Samerde/review GitHub setup Update agents and skills with broad support for Claude, Codex, and GitHub Copilot May 18, 2026
Copy link
Copy Markdown
Contributor

Copilot AI commented May 18, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • management.azure.com
    • Triggering command: /usr/bin/pwsh pwsh -NoLogo -NoProfile -File ./powershell/tests/pester.ps1 -TestFunctions: -Include Manifest.Tests.ps1 -Output None (dns block)
  • us.i.posthog.com
    • Triggering command: /usr/bin/pwsh pwsh -NoLogo -NoProfile -File ./powershell/tests/pester.ps1 -TestFunctions: -Include Manifest.Tests.ps1 -Output None (dns block)
  • www.powershellgallery.com
    • Triggering command: /usr/bin/pwsh pwsh -NoLogo -NoProfile -File ./powershell/tests/pester.ps1 -TestFunctions: -Include Manifest.Tests.ps1 -Output None (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants