Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// README for image at: https://github.com/devcontainers/templates/tree/main/src/javascript-node
{
"name": "Maester",
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-18-bullseye",
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-20-bullseye",
"features": {
"ghcr.io/devcontainers/features/powershell:2": {
"modules": "Microsoft.Graph.Authentication, Pester, PSFramework, PSModuleDevelopment, PSScriptAnalyzer"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v6.3.0
with:
node-version: "18"
node-version: "20"
cache: "npm"
cache-dependency-path: report/package-lock.json

Expand Down
4 changes: 1 addition & 3 deletions report/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ It uses vite-plugin-singlefile to generate a single HTML file which will be used

### Pre-requisites

- [Node.js](https://nodejs.org/en/download/) version 18.0 or above (which can be checked by running `node -v`). You can use [nvm](https://github.com/nvm-sh/nvm) for managing multiple Node versions on a single machine installed.
- [Node.js](https://nodejs.org/en/download/) version 20.0 or above (which can be checked by running `node -v`). You can use [nvm](https://github.com/nvm-sh/nvm) for managing multiple Node versions on a single machine installed.
- When installing Node.js, you are recommended to check all checkboxes related to dependencies.

### First time run
Expand Down Expand Up @@ -62,5 +62,3 @@ When making updates to the report you might want to bring in some fresh data to
### Submitting a Pull-Request

When submitting a PR for changes in `/report/src` you can skip updating the `/powershell/assets/ReportTemplate.html` artifact. The [report-build](https://github.com/maester365/maester/blob/main/.github/workflows/build-report.yaml) bot will build and create a PR to merge the ReportTemplate once your PR is approved and merged.


9 changes: 6 additions & 3 deletions report/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions report/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,8 @@
"typescript": "^5.0.0",
"vite": "^6.0.0",
"vite-plugin-singlefile": "^2.3.0"
},
"engines": {
"node": ">=20.0"
}
}
3 changes: 2 additions & 1 deletion website/docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ When contributing tests, please ensure the following:
- [x] Decide if the test should go into an existing .Tests.ps1

#### Writing the test

- [x] Decide in which folder the test should live. See **Test folder convention** above.
- [x] Decide if you are going to add the test to an existing .Tests.ps1 file or create a new one. E.g. If it's CA related you can add to the existing CA tests file. Don't stress over this, it's easy to move it around at any time.
- [x] Follow the guide at [Writing custom tests - Advanced Guide](/docs/writing-tests/advanced-concepts) to write your test.
Expand Down Expand Up @@ -122,7 +123,7 @@ Follow this guide if you want to run the documentation locally and view changes

#### Pre-requisites

[Node.js](https://nodejs.org/en/download/) version 18.0 or above (which can be checked by running node -v). When installing Node.js, you are recommended to check all checkboxes related to dependencies.
[Node.js](https://nodejs.org/en/download/) version 20.0 or above (which can be checked by running node -v). When installing Node.js, you are recommended to check all checkboxes related to dependencies.

#### Installation

Expand Down
126 changes: 84 additions & 42 deletions website/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@
]
},
"engines": {
"node": ">=18.0"
"node": ">=20.0"
}
}
2 changes: 1 addition & 1 deletion website/versioned_docs/version-2.0.0/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Follow this guide if you want to run the documentation locally and view changes

#### Pre-requisites

[Node.js](https://nodejs.org/en/download/) version 18.0 or above (which can be checked by running node -v). When installing Node.js, you are recommended to check all checkboxes related to dependencies.
[Node.js](https://nodejs.org/en/download/) version 20.0 or above (which can be checked by running node -v). When installing Node.js, you are recommended to check all checkboxes related to dependencies.

#### Installation

Expand Down
Loading