FIX EIDSCA.AS04: Authentication Method - SMS - Use for sign-in.#1490
Open
ThorNicolai wants to merge 2 commits intomaester365:mainfrom
Open
FIX EIDSCA.AS04: Authentication Method - SMS - Use for sign-in.#1490ThorNicolai wants to merge 2 commits intomaester365:mainfrom
ThorNicolai wants to merge 2 commits intomaester365:mainfrom
Conversation
Treat includeTargets as an array and detect when the tenant setting is not explicitly set. Compute failingTargets where isUsableForSignIn != 'false', set tenantValue/testResult accordingly, and fetch directory objects to include display names for failing targets. Produce a clearer, detailed markdown summary listing each failing target and its isUsableForSignIn value and improve handling of the not-set case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
User Bennell flagged an issue in discord related to multiple groups assigned to the SMS Authentication Method and this EIDSCA.AS04 test. The returned value would be 'False False' if for example 2 groups are assigned to the Authentication method SMS rather than 'False'. Marking the test as failed, where it would actually have passed if logic was set correctly.
Compute failingTargets where isUsableForSignIn != 'false', set tenantValue/testResult accordingly, and fetch directory objects to include display names for failing targets.
Contribution Checklist
Before submitting this PR, please confirm you have completed the following:
/powershell/tests/pester.ps1on your local system.