Reset pressed keys when reseting modifiers#171
Open
EtienneLem wants to merge 1 commit intomadrobby:masterfrom
Open
Reset pressed keys when reseting modifiers#171EtienneLem wants to merge 1 commit intomadrobby:masterfrom
EtienneLem wants to merge 1 commit intomadrobby:masterfrom
Conversation
aka when re-focusing window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aka when re-focusing window.
Teh problem
In our app we use
key.isPressed(KEYS.ALT)to detect whenaltis pressed to execute some alternate-power-user-hidden actions. 💪We noticed that very often
altis being detected as pressed while it was in fact: Not pressed. 😱Teh steps
This can be reproducible quite easily (especially when
altis being used for Alfred or Spotlight):altaltconsole.log(key.isPressed(18), key.getPressedKeyCodes()). 💥In long-lived apps, you’ll notice that
key.getPressedKeyCodes()tends to get bigger and bigger. The only way to reset it is finding and pressing all the keys present in the array. 😅Teh fix
Reseting
_downKeysonresetModifiersfixes that. 🤘I can’t really think of a false-positive or unexpected behaviour since
key.isPresseddon’t work for keys pressed prior to focusing page/app.