Skip to content

⚒️ Forge: Resolve clippy warnings in swebench and webhook test helpers#615

Open
madmax983 wants to merge 1 commit into
trunkfrom
forge/resolve-clippy-warnings-swebench-webhook-4350193815485715904
Open

⚒️ Forge: Resolve clippy warnings in swebench and webhook test helpers#615
madmax983 wants to merge 1 commit into
trunkfrom
forge/resolve-clippy-warnings-swebench-webhook-4350193815485715904

Conversation

@madmax983
Copy link
Copy Markdown
Owner

  • 🚰 Smell: Non-idiomatic loops and unhandled match variants, specifically a loop { match ... } pattern that can be simplified, wildcard Err(_) matches that obscure specific errors, and .map().unwrap_or() chains that are less readable.
  • ✨ Solution: Refactored a loop into a while let in swebench.rs. Replaced Err(_) wildcards with explicit Err(tokio::time::error::Elapsed { .. }) in sweep_webhook.rs. Simplified Option chains using .map_or() in sweep_webhook.rs.
  • 🧼 Benefit: Improves code readability, adheres to idiomatic Rust patterns (as enforced by clippy), and explicitly handles timeout errors.
  • 🛡️ Verification: Ran cargo fmt, cargo clippy --all-targets --all-features -- -D warnings, and cargo test successfully without behavior changes.

PR created automatically by Jules for task 4350193815485715904 started by @madmax983

- Refactored `loop` to `while let` in `src/run/swebench.rs`
- Replaced wildcard `Err(_)` with explicit `Err(tokio::time::error::Elapsed { .. })` in `src/stream/sweep_webhook.rs`
- Refactored `.map().unwrap_or()` to `.map_or()` in `src/stream/sweep_webhook.rs`

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies socket reading logic in swebench.rs by replacing a loop-match construct with a while let loop. It also refactors test timeout handling in sweep_webhook.rs to explicitly match tokio::time::error::Elapsed instead of using a wildcard pattern, and simplifies string parsing in body_of using map_or. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.26%. Comparing base (472ab09) to head (d6847ec).

Files with missing lines Patch % Lines
src/stream/sweep_webhook.rs 33.33% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #615      +/-   ##
==========================================
- Coverage   85.26%   85.26%   -0.01%     
==========================================
  Files         115      115              
  Lines       65856    65854       -2     
==========================================
- Hits        56150    56148       -2     
  Misses       9706     9706              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant