⚒️ Forge: Resolve clippy warnings in swebench and webhook test helpers#615
⚒️ Forge: Resolve clippy warnings in swebench and webhook test helpers#615madmax983 wants to merge 1 commit into
Conversation
- Refactored `loop` to `while let` in `src/run/swebench.rs`
- Replaced wildcard `Err(_)` with explicit `Err(tokio::time::error::Elapsed { .. })` in `src/stream/sweep_webhook.rs`
- Refactored `.map().unwrap_or()` to `.map_or()` in `src/stream/sweep_webhook.rs`
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request simplifies socket reading logic in swebench.rs by replacing a loop-match construct with a while let loop. It also refactors test timeout handling in sweep_webhook.rs to explicitly match tokio::time::error::Elapsed instead of using a wildcard pattern, and simplifies string parsing in body_of using map_or. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## trunk #615 +/- ##
==========================================
- Coverage 85.26% 85.26% -0.01%
==========================================
Files 115 115
Lines 65856 65854 -2
==========================================
- Hits 56150 56148 -2
Misses 9706 9706 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
loop { match ... }pattern that can be simplified, wildcardErr(_)matches that obscure specific errors, and.map().unwrap_or()chains that are less readable.loopinto awhile letinswebench.rs. ReplacedErr(_)wildcards with explicitErr(tokio::time::error::Elapsed { .. })insweep_webhook.rs. Simplified Option chains using.map_or()insweep_webhook.rs.cargo fmt,cargo clippy --all-targets --all-features -- -D warnings, andcargo testsuccessfully without behavior changes.PR created automatically by Jules for task 4350193815485715904 started by @madmax983