🎨 Mosaic: UI Polish for agent best-of#601
Conversation
🖌️ Before: The agent best-of command output a text-based summary table using simple println! macros. ✨ After: Formatted the summary table using the comfy_table crate. Added agent best-of to the catalog. 🖼️ Visuals: The new table uses a structured layout matching the other commands. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b1b0d3b82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CatalogEntry { | ||
| path: "agent best-of", |
There was a problem hiding this comment.
When catalog is rendered, run_catalog clones and sorts every item from entries() before printing or serializing it, so this added duplicate makes agent best-of appear twice in both text and JSON catalog output. That breaks the catalog's role as a unique command registry and can confuse consumers that iterate the commands list rather than de-duplicating paths.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request registers the new agent best-of command in the CLI catalog and refactors the run summary output in src/run/best_of.rs to use the comfy_table library for a cleaner, structured layout. Feedback on the changes suggests that the agent best-of entry may be duplicated in the catalog and recommends removing the duplicate entry.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| CatalogEntry { | ||
| path: "agent best-of", | ||
| summary: "Sample N runs and emit the best patch by --verify oracle", | ||
| cost_tier: "paid", | ||
| stage: "run", | ||
| }, |
There was a problem hiding this comment.
The agent best-of command entry is duplicated in the catalog. Since it is already defined on lines 64–68, this second entry should be removed to prevent duplicate entries in the catalog output.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #601 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 114 114
Lines 65408 65428 +20
=======================================
+ Hits 55725 55743 +18
- Misses 9683 9685 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
🖌️ Before: The agent best-of command output a text-based summary table using simple println! macros.
✨ After: Formatted the summary table using the comfy_table crate. Added agent best-of to the catalog.
🖼️ Visuals: The new table uses a structured layout matching the other commands.
PR created automatically by Jules for task 5015369416342517717 started by @madmax983