Open
Conversation
katcipis
approved these changes
Apr 1, 2022
Member
katcipis
left a comment
katcipis
left a comment
There was a problem hiding this comment.
Great stuff man, sorry for the late review 🚀
| DOCKER_DBPORT=3306 | ||
| DOCKER_DBADDR=$(DOCKER_DBHOST):$(DOCKER_DBPORT) | ||
|
|
||
| ASROOT=sudo |
Member
There was a problem hiding this comment.
I would be very curious if we can't make this work with podman 100% sudoless, this sudo stuff/sudo group shit on docker always annoyed me x_x. But unrelated to the PR, just sharing etc.
Comment on lines
+6
to
+20
| # help | ||
|
|
||
| ``` | ||
| $ make help | ||
| usage: make [target] ... | ||
|
|
||
| targets: | ||
| db: Start db | ||
| dbcli: connects and retrieves a database a shell. | ||
| dbtest: test db connectivity | ||
| build: build sqli | ||
| up: build, setup db and start sqli service. | ||
| run: run | ||
| help: Show this help message. | ||
| ``` |
Member
There was a problem hiding this comment.
Suggested change
| # help | |
| ``` | |
| $ make help | |
| usage: make [target] ... | |
| targets: | |
| db: Start db | |
| dbcli: connects and retrieves a database a shell. | |
| dbtest: test db connectivity | |
| build: build sqli | |
| up: build, setup db and start sqli service. | |
| run: run | |
| help: Show this help message. | |
| ``` | |
| # help | |
| Just run `make help`. |
Rationale: Copying the help here will only make the docs eventually outdated.
| func writeBanner(w http.ResponseWriter) { | ||
| fmt.Fprintf(w, | ||
| `+------------------------------------------------------------------------------+ | ||
| | madlambda news network | |
|
|
||
| INSERT INTO users (user,pass) VALUES | ||
| ("admin", "very-secret-pass"), | ||
| ("i4k", "****************"), |
Member
There was a problem hiding this comment.
Suggested change
| ("i4k", "****************"), | |
| ("i4k", "i love ken thompson"), |
😆
| ( | ||
| "Russia retreats from crypto ban as it pushes rules for industry", | ||
| "Russias Ministry of Finance is planning to regulate cryptocurrencies in the country, despite earlier calls by the central bank for a ban on crypto." | ||
| ); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.