Conversation
Signed-off-by: Tiago <tiago.natel@neoway.com.br>
katcipis
left a comment
katcipis
left a comment
There was a problem hiding this comment.
It would be cool do add some docs on this. But to be honest I was hoping to get the whole documentation thing for nash working properly before, things are kinda README/messy right now.
| fmt.Println() | ||
| } | ||
|
|
||
| func lookFn(stdout, stderr io.Writer, fname string, pack string, pattern *regexp.Regexp) { |
There was a problem hiding this comment.
Why just the first parameters omits type ?
| "testing" | ||
| ) | ||
|
|
||
| type ( |
There was a problem hiding this comment.
Just one type inside type() ? Some reason for this ? consistency ?
| } | ||
|
|
||
| func TestDoc(t *testing.T) { | ||
| for _, test := range []testTbl{ |
There was a problem hiding this comment.
Show struct initialization with the field names some love :-), again kind'a hard to understand what is each of the fields.
| "regexp" | ||
| ) | ||
|
|
||
| const banner = `888b 888 888 888 888888 |
|
|
||
| } | ||
|
|
||
| # carrr |
There was a problem hiding this comment.
One a lisper always a lisper :-P
|
Sorry about this code... I just found this old branch on my computer and then I pushed it to remember to improve it... |
|
Sorry to not be helping with more code yet, but I'm starting to hang around more, taking a look at the internal/sh package right now :-) |
|
|
3 participants
No description provided.