Fix ModuleManager selector for experiment definitions#6
Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
Closed
Fix ModuleManager selector for experiment definitions#6Sean-Kenneth-Doherty wants to merge 1 commit into
Sean-Kenneth-Doherty wants to merge 1 commit into
Conversation
Author
|
Closing this draft after checking the current CKAN-compatible continuation. The maintained source already removed the broken selector, so this old-repo PR is no longer a useful review target. |
Author
|
Correction to my close note: I meant the maintained tekaohksp/Science-Full-Reward source already removed the broken [*] selector. This old-repo draft is therefore no longer a useful review target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[*]name selector soEXPERIMENT_DEFINITIONnodes withoutnamevalues are matched again~id[deployed*]:LAST[Science-Full-reward]so it is outside ModuleManager legacy pass orderingWhy
Issue #2 and PR #3 identify that
@EXPERIMENT_DEFINITION[*]stopped matching these nodes after ModuleManager tightened selector handling. PR #5 fixes theidfilter syntax but leaves the[*]selector in place, so the patch can still miss experiments that only haveidvalues.KSP 1.12.5 stock and Breaking Ground
EXPERIMENT_DEFINITIONnodes useid, notname. The current selector therefore matches no definitions in that install, while the corrected selector keeps the intended deployed experiment exclusion.Validation
git diff --check/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program/GameData.bak/Squad/Resources/ScienceDefs.cfgand/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program/GameData.bak/SquadExpansion/Serenity/Resources/ScienceDefs.cfgfrom KSP 1.12.5.3190: old name-wildcard selector matches 0 definitions; corrected non-deployed selector matches 52 definitions and excludes 4 deployed definitions; 12 matched definitions havescienceCapdifferent frombaseValue.ModuleManager.4.2.3.dll.Caveat
This is draft because I only validated the selector statically. I did not run a live KSP session; the active
GameDatapath in my local install is a broken symlink, thoughGameData.bakcontains the stock/DLC definitions used for the check.