Skip to content

Fix ModuleManager selector for experiment definitions#6

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
maculator:masterfrom
Sean-Kenneth-Doherty:fix-modulemanager-selector
Closed

Fix ModuleManager selector for experiment definitions#6
Sean-Kenneth-Doherty wants to merge 1 commit into
maculator:masterfrom
Sean-Kenneth-Doherty:fix-modulemanager-selector

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • remove the [*] name selector so EXPERIMENT_DEFINITION nodes without name values are matched again
  • change the deployed-experiment exclusion from node-negation to value-negation with ~id[deployed*]
  • run the patch in :LAST[Science-Full-reward] so it is outside ModuleManager legacy pass ordering

Why

Issue #2 and PR #3 identify that @EXPERIMENT_DEFINITION[*] stopped matching these nodes after ModuleManager tightened selector handling. PR #5 fixes the id filter syntax but leaves the [*] selector in place, so the patch can still miss experiments that only have id values.

KSP 1.12.5 stock and Breaking Ground EXPERIMENT_DEFINITION nodes use id, not name. The current selector therefore matches no definitions in that install, while the corrected selector keeps the intended deployed experiment exclusion.

Validation

  • git diff --check
  • Static check against /home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program/GameData.bak/Squad/Resources/ScienceDefs.cfg and /home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program/GameData.bak/SquadExpansion/Serenity/Resources/ScienceDefs.cfg from KSP 1.12.5.3190: old name-wildcard selector matches 0 definitions; corrected non-deployed selector matches 52 definitions and excludes 4 deployed definitions; 12 matched definitions have scienceCap different from baseValue.
  • Confirmed installed ModuleManager DLL in that KSP backup is ModuleManager.4.2.3.dll.

Caveat

This is draft because I only validated the selector statically. I did not run a live KSP session; the active GameData path in my local install is a broken symlink, though GameData.bak contains the stock/DLC definitions used for the check.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Closing this draft after checking the current CKAN-compatible continuation. The maintained source already removed the broken selector, so this old-repo PR is no longer a useful review target.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Correction to my close note: I meant the maintained tekaohksp/Science-Full-Reward source already removed the broken [*] selector. This old-repo draft is therefore no longer a useful review target.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the fix-modulemanager-selector branch May 18, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant