Skip to content

Allow ids to have colons #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bousmahawassel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow ids to have colons #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion p2pnetwork/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def run(self):
connected_node_port = client_address[1] # backward compatibilty
connected_node_id = connection.recv(4096).decode('utf-8')
if ":" in connected_node_id:
(connected_node_id, connected_node_port) = connected_node_id.split(':') # When a node is connected, it sends it id!
(connected_node_id, connected_node_port) = connected_node_id.rsplit(':', 1) # When a node is connected, it sends it id!
connection.send(self.id.encode('utf-8')) # Send my id to the connected node!

thread_client = self.create_new_connection(connection, connected_node_id, client_address[0], connected_node_port)
Expand Down