Skip to content

feat(github): only notify people who are participants in the pr#4080

Merged
whutchinson98 merged 2 commits into
mainfrom
whutchinson98/macro-1829-better-github-notifications
Jun 15, 2026
Merged

feat(github): only notify people who are participants in the pr#4080
whutchinson98 merged 2 commits into
mainfrom
whutchinson98/macro-1829-better-github-notifications

Conversation

@whutchinson98

Copy link
Copy Markdown
Member

No description provided.

@macro-application

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6d218c7-a75b-419b-b5b2-d1e1a0c17018

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR introduces participant-scoped notification filtering for GitHub pull requests. A new participant_github_user_ids: Vec<String> field is added to PullRequestForeignEntityUpsert, populated by extracting participantGithubUserIds from the serialized foreign-entity metadata. New helpers in notify_pr.rs collect those GitHub user IDs from the enriched PR and each upsert, resolve them to Macro user IDs via repo.get_macro_id_by_github_user_id, and compute a participant-scoped recipient set by intersecting with the source's normal recipients. notify_pr_status_transitions now uses this set and skips notifications entirely when no participant-scoped users exist. notify_pr_comment_and_mentions similarly restricts comment fan-out to participants minus mention recipients. Tests are updated with a PullRequestWebhookParticipants struct, new webhook event builder, and participant-seeding helper covering positive, negative, and fallback scenarios.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the changes, their purpose, and any relevant context or implementation details.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'feat:' prefix and is 63 characters, well under the 72-character limit.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@whutchinson98 whutchinson98 merged commit 985a52b into main Jun 15, 2026
21 checks passed
@whutchinson98 whutchinson98 deleted the whutchinson98/macro-1829-better-github-notifications branch June 15, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant