Bf/controller iface #121
Draft
Bf/controller iface #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the IOControl class. It is now the IOController interface. The
class only forwarded behaviour to the underlying classes so it did not
need to exist
- Implements the interface on speedgoat, raspi, sil. Currently, the
interface passes an abstract `iocontrol.[Analog,Digital]Pin` to
each `Read` or `Write` function which requires each class to
verify the pin's type. The fail on type mismatch behaviour is
identical to what the `IOControl` class used to check, but with
the logic further down. I intend to use th eh eh he eh eh
- Updates hilapp to use the new interface
- Rename SetDigital to WriteDigital to be consistent with WriteAnalog
Previous heirarchy was `PinType -> Revision -> Pin`. Now it is `Revision -> PinType -> Pin`. This means every revision has the same structure (4 maps of pins for DI DO AI AO) and we don't need to check if the revision has each. Fix an import loop
BlakeFreer
force-pushed
the
bf/controller-iface
branch
from
f24dcb0 to
c401b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.