Skip to content

Restore _ordered fields handling#51

Open
kristjaneerik wants to merge 8 commits intomacarthur-lab:masterfrom
kristjaneerik:ordered-fields-v2
Open

Restore _ordered fields handling#51
kristjaneerik wants to merge 8 commits intomacarthur-lab:masterfrom
kristjaneerik:ordered-fields-v2

Conversation

@kristjaneerik
Copy link
Copy Markdown
Contributor

@kristjaneerik kristjaneerik commented Dec 5, 2017

Here I'm

@kristjaneerik
Copy link
Copy Markdown
Contributor Author

kristjaneerik commented Dec 8, 2017

I checked in results from the newest, 2017-12 dataset.

I also ran master on that dataset and diff-ed the output for b37/single using the src/comparing_clinvar_alleles.py script I added. Only differences are in the _ordered fields for most files, as expected.

The clinvar_alleles_with_gnomad_exomes files differ for two variants (variation_ids 9741 and 9754), which end up getting nan values for some columns for the run with this branch. They are both variants in SRY (e.g. https://www.ncbi.nlm.nih.gov/clinvar/variation/9741/), so I suspect it's because of the check I added for ignoring chrY for gnomad. Happy to revert that. I added it because there were issues when I ran the code many months ago. I used the r2.0.2 release for gnomAD now, but was using an older release previously, which didn't have any chrY variants while this one does. Thoughts?

One additional note is that I used normalize.py from here: ericminikel/minimal_representation#1

@kristjaneerik kristjaneerik changed the title [WIP] Restore _ordered fields handling Restore _ordered fields handling Dec 12, 2017
@kristjaneerik
Copy link
Copy Markdown
Contributor Author

@bw2 any comments on this? Happy to run it on the 2018-02 release.

@holtgrewe
Copy link
Copy Markdown

Any news on this?

@bw2
Copy link
Copy Markdown
Contributor

bw2 commented Nov 8, 2018

@holtgrewe You can use this branch, but we have deprecated the overall repo and are no longer maintaining it. (please see the note in the README)

@holtgrewe
Copy link
Copy Markdown

Hi @bw2. I'm sorry to hear this. Are you aware of some alternative source for a "digested" ClinVar database?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clinical Significance Order Lost in Allele Grouping

3 participants