Skip to content

remove pyarrow dependency#63

Merged
joocer merged 1 commit into
mainfrom
copilot/update-jsonl-reader-draken-vectors
Oct 25, 2025
Merged

remove pyarrow dependency#63
joocer merged 1 commit into
mainfrom
copilot/update-jsonl-reader-draken-vectors

Conversation

@joocer

@joocer joocer commented Oct 25, 2025

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings October 25, 2025 21:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the pyarrow dependency from the project's core dependencies, simplifying the package requirements while maintaining the draken dependency.

  • Removed pyarrow from the required dependencies list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
dependencies = [
"draken",
"pyarrow",
"draken"

Copilot AI Oct 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing pyarrow may break existing functionality that depends on it. Ensure that either: (1) pyarrow is no longer used anywhere in the codebase, (2) it's been moved to optional-dependencies if still needed for certain features, or (3) the draken package now includes pyarrow as its own dependency. The keywords list still includes 'parquet' which typically requires pyarrow, suggesting this dependency may still be needed.

Suggested change
"draken"
"draken",
"pyarrow"

Copilot uses AI. Check for mistakes.
@joocer joocer merged commit 2d5eb07 into main Oct 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants