Add Haskell bindings for oxbitnet (Issue #8)#28
Merged
Conversation
Wrap the oxbitnet-ffi C API via Haskell's FFI (hsc2hs) for type-safe, cross-platform struct layout. High-level API uses MVar + bracket for thread-safe resource management, with IO Bool token callbacks for idiomatic early stopping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep both C# (NuGet) and Haskell (Hackage) CI jobs and version checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxbitnet-ffivia hsc2hs for correct cross-platform struct layoutOxBitNetmodule) withMVar+bracketfor thread-safe resource management,IO Booltoken callbacks, and typed exceptionsForeign.OxBitNet.Raw) with Storable instances, callback wrappers, and safe/unsafe FFI importsoxbitnet-chat)oxbitnet.cabal+publish-hackagejob (GHC 9.6, Cabal 3.10, source-only Hackage upload)Design decisions
MVar (Maybe (Ptr OxBitNet))instead ofForeignPtr—oxbitnet_freeblocks (tokio runtime shutdown), unsafe on GC finalizer threadsafeFFI for load/generate/chat (long-running + callbacks);unsafefor free/error_message/defaultsIO Bool(True = stop) — more idiomatic Haskell thanInt32FunPtrintentionally leaked (process-lifetime, matching C API contract)liboxbitnet_ffiTest plan
cargo build -p oxbitnet-ffi --releasethencabal build alloxbitnet-chatwith a GGUF model, verify streaming output + progressfreeBitNet/ bracket cleanupoxbitnet.cabalcorrectlyCloses #8
🤖 Generated with Claude Code