fix(compact): clear a compaction banner that outlived its timer #94
Merged
Conversation
…sume The compaction indicator could linger over the resumed model: the `aboveEditor`/dashboard "Compacting… 95%" banner stayed up while the model was already thinking, calling planner_status, and running tests after the compaction had ended. The resume hooks (agent_start / turn_start / message_start) tore the banner down only when the closure's own `compactTimer` interval was still live. But the banner line is module-level (mirrored into /planner-dashboard) and can outlive that timer — a re-registration on /reload leaves a fresh interval at null while the old banner line still shows. Gating solely on the timer then skipped the clear and the stale banner survived every resume signal. Consult the durable banner state too: clear when EITHER the interval is live OR the shared banner line is still up. Summarization blocks the agent loop, so any resume signal means the compaction is genuinely over, making the force-clear safe. The clear is a no-op outside planner mode (the banner is only ever set while a plan is active), so it never touches Pi's own UX. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
….10.0) package.json drifted to 0.11.0 in #85 while the latest npm release is still 0.10.0 (package-lock.json was never bumped, so it already read 0.10.0). The working tree should track the published version; the release bump is applied by CI from the tag, not carried ahead in main. Reset to 0.10.0 so the two match again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.