Remove blocking semaphore, display initial state and allow large matrix#14
Open
brice-fr wants to merge 17 commits intom5stack:masterfrom
Open
Remove blocking semaphore, display initial state and allow large matrix#14brice-fr wants to merge 17 commits intom5stack:masterfrom
brice-fr wants to merge 17 commits intom5stack:masterfrom
Conversation
Specifying the library dependencies in the depends field of library.properties causes the Arduino Library Manager (Arduino IDE 1.8.10 and newer) to offer to install any missing dependencies during installation of this library. "arduino-cli lib install" will automatically install the dependencies (arduino-cli 0.7.0 and newer).
…SemaphoreTake/Give and correcting some typos The xSemaphoreTake(_xSemaphore, portMAX_DELAY); in LED_Display::displaybuff was taking a second time the _xSemaphore that had already been taken in LED_Display::run() in the same execution flow and was halting the execution of the program xSemaphoreGive(_xSemaphore); in LED_Display::displaybuff has also been removed To keep things consistent, the FastLED.setBrightness(20); has been put after FastLED.show(); in LED_Display::run Some english typo were also corrected
…k-and-some-typos Update and rename Display.cpp, removing the blocking xSemaphoreTake
…of numeric constant Minor typo corrections to match those of LED_Display.cpp
With the previous code, the initial state (_count_x,_count_y) = (0,0) was never displayed. Here the buffer is calculated before the increment/decrement. As a side effect the total animation count shall be increased by one unit to display the last line
Following change in LED_Display.cpp to display the initial state, another 1 count is necessary to display the M fully.
int8_t offset limits scrolling to 127 whereas it is supposed to be able to be incremented or decremented several times the pixel size of the initial buffer
to allow large matrix scrolling. Also deleted unused declaration
Large matrix scrolling
Update type of setdatax and setdatay to allow display of large matrix
Corrected max number of LEDs with #define NUM_LEDS value
Initial state never displayed
Specify library dependencies in library.properties
Contributor
|
So this is months old, why hasn't someone from M5Stack at least commented on this? Merge it? |
|
Wish I'd seen this earlier - I suspected a major bug in the animation code and was confused by the use of a semaphore. I wrote my own horizontal scroller logic (which is all I needed) to work around the issues in my own project Atomic Text. I'm somewhat shocked too that this hasn't been merged in either or the Atom library itself updated since January. |
Gitshaoxiang
force-pushed
the
master
branch
2 times, most recently
from
1f655c5 to
6fc5dd1
Compare
Gitshaoxiang
force-pushed
the
master
branch
3 times, most recently
from
4b980ca to
3a08358
Compare
Member
|
Hi, can you please enable Allow edits from maintainers, I need to format the code. |
TinyuZhao
force-pushed
the
master
branch
3 times, most recently
from
8a38424 to
e1f2cb9
Compare
Gitshaoxiang
force-pushed
the
master
branch
14 times, most recently
from
da21aa5 to
065681c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual library LED_Display animations are not working due to blocking semaphore
The initial state (offset 0,0) of the buffer is never displayed in animations
Large buffer matrix can not be displayed or wrapped around due to limited offset type
Various minor english typo corrections