Check resource before closing stream handle #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the specific Flysystem Adapter wrote the stream, it might have closed it.
So we double-check before trying to close it again.
This happens for
league/flysystem-aws-s3-v3->aws/aws-sdk-php->guzzlehttp/psr7and stream is wrapped inGuzzleHttp\Psr7\Streamthat on destruct closes it.Maybe they shouldn't close it, but we're not in control of it. So double-checking sounds reasonable.