Open
Conversation
- Enhanced the implementation of beads for better tracking of AI tasks and session memory management. - Refined the integration to ensure smoother operation and improved user experience.
…m to soundConfig.ts
… all required fields
…m to soundConfig.ts
… all required fields
…onal pan field to layerSchema
…unction in synthCore.ts with gain target support
… to createLayerLFO function
…yerLFO function for oscillator detune
… sync modes in createLayerLFO
…tatic synthesizer
… realtime synthesizer
…eoPannerNode in layer processing
…teLayerLFO for FM modulation depth
…teLayerLFO for filter resonance modulation
…ove stale wip-docs
Fix type errors: LayerLFOConfig sync field, duplicate clamp export, FM schema, ArrayBuffer casts
Confirmed backward compatibility via existing tests: lfos field is optional, all example configs validate without LFO-related errors.
…ach note-on event
…e-on Each call to createLayerLFO creates a new oscillator starting at phase 0, ensuring retrigger mode correctly resets LFO phase on each note trigger.
Verified synthesizer.ts correctly calls createLayerLFO for all layer LFOs during offline rendering. All 6 modulation targets functional.
… and fix pan routing - Add 11 integration tests verifying all 6 LFO modulation targets work in offline synthesis - Fix pan LFO routing to insert panner in signal chain before layerGain - Use property check instead of instanceof for StereoPannerNode (test compatibility)
…or FM layer types Verified existing implementation in LayerLFOEditor.tsx that conditionally shows fmIndex only when layer.type === 'fm'.
… in real-time synth Verified realtimeSynth.ts already uses shared createLayerLFO function for all 6 modulation targets with proper source tracking and cleanup.
…on FM layers for evolving timbres
…rato effect in offline synthesis
…ad correctly in presets
… tempo multiplier
…thesis Free sync mode now runs LFOs continuously without phase reset between notes. Implemented persistent LFO storage in RealtimeSynth that creates shared LFO oscillators for 'free' mode, with per-voice modulation routing. Retrigger and tempo modes still create per-voice LFOs as before.
…ovement in offline synthesis
…ware options based on layer type
… within layer panel
…ns for quick waveform switching
… only when tempo sync mode is active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.