fix and update code to run on current library versions#1
Open
mdecker wants to merge 1 commit intom-ri:masterfrom
Open
fix and update code to run on current library versions#1mdecker wants to merge 1 commit intom-ri:masterfrom
mdecker wants to merge 1 commit intom-ri:masterfrom
Conversation
- move subscribe to on_connect - only subscribe to topics actually required - fix number of expected topics - move QoS setting and number of expected topics to top-level scope - only print performance data when all required data is available (avoids KeyError) tested with: mosquitto 2.0.11, paho-mqtt 1.4.0, Debian 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your code. I needed to make some changes to have it run on my system. I assume it might be because of changes to the mqtt library or server over the past 3+ years. In any case: This code works for me. So feel free to merge it.
Key changes I made:
tested with: mosquitto 2.0.11, paho-mqtt 1.4.0, Debian 10