Build Mixtapes for macOS#43
Open
leoluniere wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Unfortunately I have no experience with Python neither macOS app development, so currently I have no idea how to implement the Media Controls for Mixtapes on Mac. |
Owner
|
I’m gonna try to spin up an OSX-KVM virtual machine soon and see if I can fix the issues myself 👍 I just needed to confirm that it works |
Owner
|
I'm gonna try some other day, the VM makes debugging tedious |
Owner
|
but i did get it to run |
Contributor
|
I don't have a macos device, but I found it kinda strange to see so many manual binary and data imports in the pyinstaller spec. Does brew not install the libraries globally? Or maybe try using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started doing this work on another repo but ended up forking again to prevent:
In the time I'm writing this, this PR only brings:
The workflow and scripts were partly borrowed from Gajim.
The workflow builds for Apple Intel and Apple Silicon, and both were tested and confirmed to work.
The following things aren't working/need to be implemented:
1: The file is compiled with glib and imported by Pyinstaller in the spec file, but even the file being on the path main.py looks for (Mixtapes.app/Contents/Frameworks/), it's not loaded correctly or not at all. I didn't got to debug enough to know if the problem is when trying to import the file or finding the file as my priority was to get the workflow working.
2: login_helper.py works completely fine on Mac (Only fix is needing to use a custom user-agent) and is able to collect the cookies, but the cookies collected aren't valid for ytmusicapi (can't auth) for some reason.
Any features besides the ones already listed should be working with no major issues