Add allocate_treatments function#68
Open
Dimitry-Wintermantel wants to merge 1 commit intom-Py:mainfrom
Open
Conversation
…jects to treatment groups while balancing specified covariates
Owner
|
Hi Dimitry, thanks for your PR. Sorry for my late reaction, I was quite busy when you submitted and then forgot to get back to you sooner. I have two followup questions:
Thanks, Martin |
Author
|
Hi Martin,
Sorry, dass ich erst so spät antworte. Ich hatte ein paar Deadlines. Bin
dann noch krank geworden und habe es dann vergessen. Ich arbeite jetzt
wieder an dem Paper in dem die Funktion vorgestellt wird. Wir können das
gerne mit der Submission synchronisieren.
Viele Grüße
Dimitry
…On Thu, Mar 6, 2025 at 10:35 AM Martin Papenberg ***@***.***> wrote:
Hi Dimitry,
thanks for your PR. Sorry for my late reaction, I was quite busy when you
submitted and then forgot to get back to you sooner. I have two followup
questions:
- Could you change the target of your PR? I just created a new branch
bee_allocation, which you can use. It is (currently) identical to
main, which is however reserved for released versions of anticlust.
- Could you provide a reference for your function? As discussed, it
makes sense to explain where this function is coming from and why it is in
anticlust. I assume that a working title / manuscript in preparation
reference would suffice now. We might even synchronize when the function is
included in anticlust and when you submit / publish your paper. I
would also add to the documentation (but this is something that I can do)
that this function implements the anticlustering specification that you
used in your paper.
Thanks,
Martin
—
Reply to this email directly, view it on GitHub
<#68 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIETJRDL4RDRI2CRBSCIPBL2TAJE5AVCNFSM6AAAAABX5G4R7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBTGMYDENRXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: m-Py]*m-Py* left a comment (m-Py/anticlust#68)
<#68 (comment)>
Hi Dimitry,
thanks for your PR. Sorry for my late reaction, I was quite busy when you
submitted and then forgot to get back to you sooner. I have two followup
questions:
- Could you change the target of your PR? I just created a new branch
bee_allocation, which you can use. It is (currently) identical to
main, which is however reserved for released versions of anticlust.
- Could you provide a reference for your function? As discussed, it
makes sense to explain where this function is coming from and why it is in
anticlust. I assume that a working title / manuscript in preparation
reference would suffice now. We might even synchronize when the function is
included in anticlust and when you submit / publish your paper. I
would also add to the documentation (but this is something that I can do)
that this function implements the anticlustering specification that you
used in your paper.
Thanks,
Martin
—
Reply to this email directly, view it on GitHub
<#68 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIETJRDL4RDRI2CRBSCIPBL2TAJE5AVCNFSM6AAAAABX5G4R7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBTGMYDENRXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously agreed I now provide here the allocate_treatment function that enables balanced treatment allocation based on specified covariates. The function ensures that treatment groups are created while minimizing within-group variance and allowing constraints such as equal replicates, standardized covariates, and stratified matching within subsets.