feat: term block command config dialog with Save & Restart and error state display#9
Merged
Conversation
…state display - Add CommandConfigModal dialog (Command, Run on startup, Clear on start, Env vars) - Replace 'Run On Startup' submenu with 'Configure Command...' menu item - Inject command as keystrokes into interactive shell (not -c mode) - Write cmd:lasterror meta key on non-zero exit, clear on exit 0 - Show red error icon in block header when cmd:lasterror is set - Add MetaKey_CmdLastError to MetaTSType / metaconsts.go
… error icon guard - Clear cmd:lasterror meta at shell start and before each injection - Add shell-specific env var injection (export for bash, envvar for pwsh, set -gx for fish) - Fix error icon: only set cmd:lasterror when InjectedCommand flag is true - Use backslash-r (0x0D) instead of backslash-r-backslash-n for ConPTY keystroke injection - Add 1500ms delay for shell raw mode initialization - Convert backslash-n to backslash-r for multi-line command injection - Add clickable error icon that opens MessageModal with details - Set controller double-quote shell double-quote in Save and Restart meta (was null) - Update OpenSpec skills-workflows to v1.4.1
- Replace direct PTY write with shellInputCh channel (same path as user keystrokes) - Remove InjectedCommand tracking and cmd:lasterror meta mechanism - Remove red error icon UI for cmd blocks - Remove MetaKey_CmdLastError/CmdLastError type and generated files - Clean up unused useEffect import - Rename 'Configure Command...' to 'Startup Command...'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a command configuration dialog for terminal blocks, allowing users to configure startup commands, environment variables, and other settings at runtime.
Changes
Backend
Frontend
Key Design Decision
Command is injected as keystrokes into the interactive shell (not via -c\ flag), so the shell remains interactive after command execution.
Testing