Skip to content

Add classic custom-board support and fix ESP32 build issues #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carylhubin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add classic custom-board support and fix ESP32 build issues #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,21 @@ __pycache__/
# C extensions
*.so

# generated files
gen/api_gen/templates/module.c
gen/api_gen/templates/module/decl.c
gen/api_gen/templates/module/helpers.c
ext_mod/lvgl/lextab.py
ext_mod/lvgl/yacctab.py
lvgl.pyi

# Distribution / packaging
lib/micropython
lib/esp-idf
lib/lvgl
lib/pycparser
lib/SDL

.Python
build/
develop-eggs/
Expand Down
7 changes: 4 additions & 3 deletions builder/esp32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,8 +1339,6 @@ def update_main():


def build_sdkconfig(*args):
if custom_board_path is not None:
Copy link
Author

@carylhubin carylhubin Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This early return prevented inclusion of optional drivers (FROZEN_MANIFEST) and API generation (GEN_SCRIPT) when building for custom boards. It seems to be either an oversight or an unintended change. If this if custom_board_path is not None condition must be preserved, a flag could be added to differentiate the board type.

Copy link
Collaborator

@kdschlosser kdschlosser Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional because everything done here is able to be done in the custom board files so it is not needed. The user needs to do this themselves in those board files.

return []

base_config = [
'',
Expand Down Expand Up @@ -1411,10 +1409,13 @@ def build_sdkconfig(*args):
base_config.append(
f'CONFIG_ESPTOOLPY_FLASH_SAMPLE_MODE_{itm}=n'
)

Copy link
Collaborator

@kdschlosser kdschlosser Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded change

base_config.append(arg)
args.remove(arg)

elif arg.startswith("--"):
Copy link
Author

@carylhubin carylhubin Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom build arguments passed to make.py (e.g. --flash-size, --enable-uart) are not valid Make options.

Copy link
Collaborator

@kdschlosser kdschlosser Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no they are not, but when using a custom board those options should not be used in the build command and should instead be handled in the custom board. so when a user specifies a custom board and then uses those commands the commands are not parsed and get forwarded to makefile. What needs to be done is when a user uses a custom board and passes any arguments that should not be there an exception should be raised with a meaningful message about using those build command in combination with a custom bard.

args.remove(arg)

base_config.append(f'CONFIG_ESPTOOLPY_FLASHSIZE_{flash_size}MB=y')
base_config.append(''.join([
'CONFIG_PARTITION_TABLE_CUSTOM_FILENAME=',
Expand Down
Loading