Skip to content

Rp2 debug #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hemonu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rp2 debug #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7abdd0
intermediate commit
hemonu Dec 5, 2025
377ede3
works for SPI bus
hemonu Dec 5, 2025
96838e2
debug of i80_bus bitbang driver
hemonu Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext_mod/lcd_bus/common_include/i80_bus.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@
void *buf1;
void *buf2;

/* buffer_flags is not used, but it needs to be here
* otherwise function pointers are no more aligned
* with the pointer use in _mp_lcd_bus_obj_t
*/
uint32_t buffer_flags;

bool trans_done;
bool rgb565_byte_swap;

Expand Down
6 changes: 6 additions & 0 deletions ext_mod/lcd_bus/common_include/spi_bus.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@
void *buf1;
void *buf2;

/* buffer_flags is not used, but it needs to be here
* otherwise function pointers are no more aligned
* with the pointer use in _mp_lcd_bus_obj_t
*/
uint32_t buffer_flags;

bool trans_done;
bool rgb565_byte_swap;

Expand Down
136 changes: 80 additions & 56 deletions ext_mod/lcd_bus/common_src/i80_bus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@
mp_hal_pin_write(self->bus_config.data_gpio_nums[1], (buf[0] >> 1) & 1); \
mp_hal_pin_write(self->bus_config.data_gpio_nums[0], buf[0] & 1); \
}

// sleep_us(1) to ensure minimum WR pulse width, so that I can follow it with my logic analyzer
// can be eliminated after debugging
#define WR_PULSE() { mp_hal_pin_write(self->bus_config.wr_gpio_num, 0)/*; sleep_us(1)*/; mp_hal_pin_write(self->bus_config.wr_gpio_num, 1);; }

/* end macros */


Expand Down Expand Up @@ -102,7 +107,7 @@
*/
static mp_obj_t mp_lcd_i80_bus_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *all_args)
{
enum {
enum {
ARG_dc,
ARG_wr,
ARG_data0,
Expand All @@ -127,8 +132,8 @@
ARG_dc_cmd_high,
ARG_dc_dummy_high,
ARG_dc_data_high,
ARG_cmd_bits,
ARG_param_bits,
//ARG_cmd_bits,
//ARG_param_bits,
ARG_cs_active_high,
ARG_reverse_color_bits,
ARG_swap_color_bytes,
Expand Down Expand Up @@ -198,7 +203,8 @@

self->callback = mp_const_none;

#if !defined(mp_hal_pin_output) && !defined(IDF_VER)
// mp_hal_pin_output if a function for rp2, so I have added PICO_HEAP_SIZE
#if !defined(mp_hal_pin_output) && !defined(IDF_VER) && !defined(PICO_HEAP_SIZE)
mp_raise_msg(&mp_type_NotImplementedError, MP_ERROR_TEXT("LCD I80 but is not available for this MCU"));
#else
self->panel_io_config.user_ctx = self;
Expand All @@ -219,7 +225,7 @@
#endif /* defined(MP_HAL_PIN_SPEED_VERY_HIGH) && !defined(MICROPY_INCLUDED_MIMXRT_MPHALPORT_H) */

mp_hal_pin_write(self->bus_config.dc_gpio_num, self->panel_io_config.dc_levels.dc_data_level);
mp_hal_pin_write(self->bus_config.wr_gpio_num, 0);
mp_hal_pin_write(self->bus_config.wr_gpio_num, !self->panel_io_config.flags.cs_active_high);

self->bus_config.data_gpio_nums[0] = (mp_hal_pin_obj_t)mp_hal_get_pin_obj(args[ARG_data0].u_obj);
self->bus_config.data_gpio_nums[1] = (mp_hal_pin_obj_t)mp_hal_get_pin_obj(args[ARG_data1].u_obj);
Expand Down Expand Up @@ -284,51 +290,80 @@

CS_LOW();
DC_CMD();

if (self->bus_config.bus_width == 8) {
uint8_t *buf = NULL;
uint8_t buf[1];
if (self->panel_io_config.lcd_cmd_bits == 8) {
buf[0] = (uint8_t)lcd_cmd;
WRITE8();
} else {
buf[0] = (uint8_t)((uint16_t)lcd_cmd >> 8);
WRITE8();
WR_LOW();
WR_HIGH();
WR_PULSE();
buf[0] = (uint8_t)((uint16_t)lcd_cmd & 0xFF);
WRITE8();
}
} else {
uint16_t *buf = NULL;
uint16_t buf[1];
buf[0] = (uint16_t)lcd_cmd;
WRITE16();
}

WR_LOW();
WR_HIGH();

WR_PULSE();

DC_DATA();

if (param != NULL) {
if (self->bus_config.bus_width == 8) {
uint8_t *buf = (uint8_t *)param;
uint16_t len = (uint16_t)param_size;
while (len--) {
WRITE8();
WR_LOW();
WR_HIGH();
buf++;
}
} else {
uint16_t *buf = (uint16_t *)param;
uint16_t len = (uint16_t)(param_size / 2);
while (len--) {
WRITE16();
WR_LOW();
WR_HIGH();
buf++;
if (param_size > 0 ) {
if (self->bus_config.bus_width == 8) {
if (self->panel_io_config.lcd_cmd_bits == 8) {
// 8 bit param over 8 bit bus
uint8_t *buf = (uint8_t *)param;
uint16_t len = (uint16_t)param_size;
while (len--) {
WRITE8();
WR_PULSE();
buf++;
}
} else {
// 16 bit param over 8 bit bus
uint16_t buf[1];
uint16_t *p = (uint16_t *)param;
uint16_t len = (uint16_t)(param_size / 2);
while (len--) {
buf[0] = (uint8_t)(*p >> 8);
WRITE8();
WR_PULSE();
buf[0] = (uint8_t)(*p & 0xFF);
WRITE8();
WR_PULSE();
p++;
}
}
}
} else {
if (self->panel_io_config.lcd_cmd_bits == 8) {
// 8 bit param over 16 bit bus
uint16_t buf[1];
uint8_t *p = (uint8_t *)param;
uint16_t len = (uint16_t)param_size;
while (len--) {
buf[0] = (uint16_t)(*p);
WRITE16();
WR_PULSE();
//WR_LOW();
//WR_HIGH();
p++;
}
} else {
// 16 bit param over 16 bit bus
uint16_t *buf = (uint16_t *)param;
uint16_t len = (uint16_t)(param_size);
while (len--) {
WRITE16();
WR_PULSE();
buf++;
}
}
}
}

CS_HIGH();
Expand Down Expand Up @@ -360,25 +395,23 @@
DC_CMD();

if (self->bus_config.bus_width == 8) {
uint8_t *buf = NULL;
uint8_t buf[1];
if (self->panel_io_config.lcd_cmd_bits == 8) {
buf[0] = (uint8_t)lcd_cmd;
WRITE8();
} else {
buf[0] = (uint8_t)((uint16_t)lcd_cmd >> 8);
WRITE8();
WR_LOW();
WR_HIGH();
WR_PULSE();
buf[0] = (uint8_t)((uint16_t)lcd_cmd & 0xFF);
WRITE8();
}
} else {
uint16_t *buf = NULL;
uint16_t buf[1];
buf[0] = (uint16_t)lcd_cmd;
WRITE16();
}
WR_LOW();
WR_HIGH();
WR_PULSE();
DC_DATA();

self->write_color(self, color, color_size);
Expand Down Expand Up @@ -463,8 +496,7 @@
WRITE8();
}
buf++;
WR_LOW();
WR_HIGH();
WR_PULSE();
}
}

Expand All @@ -481,8 +513,7 @@
WRITE16();
}
buf++;
WR_LOW();
WR_HIGH();
WR_PULSE();
}
}

Expand All @@ -500,17 +531,15 @@
last = buf[0];
WRITE8();
}
WR_LOW();
WR_HIGH();
WR_PULSE();

buf = &bd[i * 2];

if (buf[0] != last) {
last = buf[0];
WRITE8();
}
WR_LOW();
WR_HIGH();
WR_PULSE();
}
}

Expand All @@ -528,17 +557,15 @@
last = buf[0];
WRITE16();
}
WR_LOW();
WR_HIGH();
WR_PULSE();

buf = &bd[i * 2];

if (buf[0] != last) {
last = buf[0];
WRITE16();
}
WR_LOW();
WR_HIGH();
WR_PULSE();
}
}

Expand All @@ -555,15 +582,13 @@
last = bd[0];
*buf = bd[0] << 8;
WRITE8();
WR_LOW();
WR_HIGH();
WR_PULSE();
*buf = bd[0] >> 8;
WRITE8();
WR_LOW();
WR_HIGH();
}
WR_LOW();
WR_HIGH();
WR_PULSE();
bd++;
}
}
Expand All @@ -581,8 +606,7 @@
last = buf[0];
WRITE16();
}
WR_LOW();
WR_HIGH();
WR_PULSE();
buf++;
}
}
Expand Down
20 changes: 15 additions & 5 deletions ext_mod/lcd_bus/common_src/spi_bus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
// local includes
#include "lcd_types.h"
#include "modlcd_bus.h"
#include "spi_bus.h"
// compiler doesn't find spi_bus.h without ../common_include/ ??
#include "../common_include/spi_bus.h"
#include "../../../micropy_updates/common/mp_spi_common.h"

// micropython includes
Expand All @@ -14,6 +15,7 @@
// #else
#include "py/obj.h"
#include "py/runtime.h"
#include "extmod/modmachine.h" // for mp_machine_p_t

// stdlib includes
#include <string.h>
Expand Down Expand Up @@ -189,23 +191,26 @@

mp_lcd_spi_bus_obj_t *self = MP_OBJ_TO_PTR(obj);

uint8_t bits;
// uint8_t bits; no more used

if (cmd_bits == 16) {
self->send_cmd = send_cmd_16;
bits = 16;
// bits = 16;
} else {
self->send_cmd = send_cmd_8;
bits = 8;
// bits = 8;
}

if (param_bits == 16) {
self->send_param = send_param_16;
bits = 16;
// bits = 16;
} else {
self->send_param = send_param_8;
}

/* constructor above takes a machine_hw_spi_device as argument
so we should not create another one

mp_obj_base_t *spi;
mp_obj_t spi_args[12];

Expand All @@ -228,6 +233,11 @@

self->bus_handle = spi;
self->panel_io_config.spi_transfer = ((mp_machine_spi_p_t *)MP_OBJ_TYPE_GET_SLOT(spi->type, protocol))->transfer;
*/

// we take the transfer pointer from the bus inside the existing device
self->bus_handle = MP_OBJ_FROM_PTR(self->spi_bus);
self->panel_io_config.spi_transfer = ((mp_machine_spi_p_t *)MP_OBJ_TYPE_GET_SLOT(&machine_spi_type, protocol))->transfer;

return LCD_OK;
}
Expand Down
Loading