Skip to content

refactor: Extract start and end handle definitions in getSelectionNodesDom function #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levivilet merged 2 commits into from
May 10, 2026
Merged

refactor: Extract start and end handle definitions in getSelectionNodesDom function #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2d644
refactor: Extract start and end handle definitions in getSelectionNod…
levivilet May 10, 2026
1687707
memory
levivilet May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/build/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { join } from 'node:path'
import { root } from './root.ts'

export const threshold = 600_000
export const threshold = 620_000

export const instantiations = 200_000

Expand Down
52 changes: 28 additions & 24 deletions packages/chat-debug-view/src/parts/GetSelectionNodesDom/GetSelectionNodesDom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,32 @@ import {
import { formatPercent } from '../FormatPercent/FormatPercent.ts'
import * as TimelineSelectionHandleName from '../TimelineSelectionHandleName/TimelineSelectionHandleName.ts'

const startHandle: VirtualDomNode = {
childCount: 0,
className: mergeClassNames(
ChatDebugViewTimelineSelectionHandle,
ChatDebugViewTimelineSelectionHandleStart,
ChatDebugViewTimelineSelectionMarker,
ChatDebugViewTimelineSelectionMarkerStart,
),
name: TimelineSelectionHandleName.Start,
role: AriaRoles.None,
type: VirtualDomElements.Button,
}

const endHandle: VirtualDomNode = {
childCount: 0,
className: mergeClassNames(
ChatDebugViewTimelineSelectionHandle,
ChatDebugViewTimelineSelectionHandleEnd,
ChatDebugViewTimelineSelectionMarker,
ChatDebugViewTimelineSelectionMarkerEnd,
),
name: TimelineSelectionHandleName.End,
role: AriaRoles.None,
type: VirtualDomElements.Button,
}

export const getSelectionNodesDom = (
hasSelection: boolean,
selectionStartPercent: number | null,
Expand All @@ -27,29 +53,7 @@ export const getSelectionNodesDom = (
style: `left:${formatPercent(selectionStartPercent)};width:${formatPercent(selectionEndPercent - selectionStartPercent)};`,
type: VirtualDomElements.Div,
},
{
childCount: 0,
className: mergeClassNames(
ChatDebugViewTimelineSelectionHandle,
ChatDebugViewTimelineSelectionHandleStart,
ChatDebugViewTimelineSelectionMarker,
ChatDebugViewTimelineSelectionMarkerStart,
),
name: TimelineSelectionHandleName.Start,
role: AriaRoles.None,
type: VirtualDomElements.Button,
},
{
childCount: 0,
className: mergeClassNames(
ChatDebugViewTimelineSelectionHandle,
ChatDebugViewTimelineSelectionHandleEnd,
ChatDebugViewTimelineSelectionMarker,
ChatDebugViewTimelineSelectionMarkerEnd,
),
name: TimelineSelectionHandleName.End,
role: AriaRoles.None,
type: VirtualDomElements.Button,
},
startHandle,
endHandle,
]
}
Loading