Remove GH spamming of precheck when PR is open#1607
Merged
MaticTonin merged 2 commits intodevelopfrom Jan 8, 2026
Merged
Conversation
aljazdu
approved these changes
Jan 7, 2026
Contributor
aljazdu
left a comment
aljazdu
left a comment
There was a problem hiding this comment.
Changes LGTM, as I agree that the spamming of empty GH workflows was annoying. The perfect solution would entail a workflow run only when a combination of synchronize and labeled would be in effect, but since we are limited by GH workflows this can not be achieved - as it is not supported.
Since re-labeling of testable will be "annoying" in this case, I would suggest that we stick to labeling when PR is already reviewed - perhaps a check for run workflows can be added at some point to avoid merging without running the workflows.
Collaborator
|
LGTM from my side, we can always revert if it won't work out well. |
moratom
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main idea is to remove spamming of GH actions when PR is open and when commits are pushed on it, since there was a lot of cases when we have branch labeled as testable and then push additional commits on it due to review changes, example below:
This should as well limit the usage of our GH runnners, but would mean that retesting of the actions would require to add + remove the label since GH no longer checks new pushed changes.