Conversation
lnotspotl
left a comment
There was a problem hiding this comment.
Left a few comments, there is a couple of edge cases that need to be handled (mainly null pointer related stuff), otherwise looks good!
|
I tried running the I might be doing something wrong? Also, in the examples, can we print out some basic info, something like Otherwise the application starts running and the user does not know what to do unless they explicitly read the code beforehand (which they don't, usually) Also, when I run |
Kazam_screencast_00008.mp4 |
Looking at the comment and the video recording you have sent, I have 2 comments. Firstly, is your code up to date? Comparing the current Secondly, the functionality of snaps works in the following way: when you call I have tried using the example.py in the current version and it worked. |
|
Thanks, @aljazdu, indeed, I had not pulled the latest changes and I can see the uploaded snaps after a while on the hub 👍 However, the issue with me uploading snaps super quickly persists, if I spam |
I will look into it and let you know. In the mean time, you can use the file_group example if you want to automate sending the snaps (it sends a snap when a detection confidence is within a certain threshold). It can be used to easily send a large number of snaps. |
Fixed the app crashing, as well as added usage print statement for the user explaining what to press. |
Perfect, great to hear! The problem was erroneous duplicated |
Purpose
This PR solves multiple minor issues with Snaps such as: missing callbacks for snap uploads, exposed device serial numbers when sending snaps, minor update of certain errors messages.
Specification
Added CallBacks to SendSnap(), which returns SendSnapCallbackResult which contains snap payload, name, timestamp, id, as well as SendSnapCallbackStatus which describes the status of snap upload.
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
This was tested using the updated examples. both in python and C++.