Conversation
jakgra
reviewed
Dec 17, 2025
Contributor
|
General "public" API looks ok from my side. We have to handle RVC4 devices better before merging. |
Collaborator
|
@JakubFara let's add the implementation on RVC4 as well, and we should be good to merge. |
JakubFara
force-pushed
the
feature/isp_output_queue
branch
5 times, most recently
from
cbaae44 to
05b724f
Compare
JakubFara
force-pushed
the
feature/isp_output_queue
branch
4 times, most recently
from
2a24315 to
db67222
Compare
JakubFara
force-pushed
the
feature/isp_output_queue
branch
3 times, most recently
from
930e668 to
3529b5d
Compare
JakubFara
force-pushed
the
feature/isp_output_queue
branch
2 times, most recently
from
3fcf6ce to
53c1319
Compare
JakubFara
force-pushed
the
feature/isp_output_queue
branch
from
e3a2b29 to
656a086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISP output
New function
Camera::requestIspOutput(std::optional<float> fps = std::nullopt)