-
Notifications
You must be signed in to change notification settings - Fork 161
Added support for a pybind11 embedded module target #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Added support for a pybind11 embedded module target #1416
Conversation
…ake configuration, installing it as a separate(dependant on core) shared lib. This allows other C++ projects to include the additional lib and use python to build its pipeline. Incompatible with depthai_nodes currently.
moratom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thehiddenwaffle !
Would you be open to also add an example and/or test for this?
I'm guessing something like a custom host node which is esentially an "on host Script node" would make sense here.
@moratom I've been thinking about it and I feel like maybe 2 examples are needed, one for each of the following cases
|
…and Python derived host nodes
|
@moratom I've added both examples, however the one that uses Python derived host nodes doesn't work yet and it seems like the synchronization between the state of the Python class and what that needs to represent on the C++ side is not tight enough. Currently it complains that the datatype that Python sets does not exist and other approaches that I've tried also fail due to similar dysfunction between Python and C++ state. Unsure what to do. The first example(the one that I developed this feature for) works perfectly. |
| case Colormap::TURBO: | ||
| case Colormap::STEREO_TURBO: | ||
| cvColormap = cv::COLORMAP_TURBO; | ||
| // cvColormap = cv::COLORMAP_TURBO; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not intended for this PR my opencv version was out of date, will remove.
Purpose
https://discuss.luxonis.com/d/6203-are-depthai-core-contributions-welcome/9
Target built by CMake configuration, installing it as a separate(dependant on core) shared lib. This allows other C++ projects to include the additional lib and use python to build its pipeline. Incompatible with depthai_nodes currently.
Specification
strictly additive, disabled by default
Testing & Validation
Successfully using from a separate project locally.