Skip to content

Fix ASAN/UBSAN issues #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aljazdu merged 3 commits into from
Jan 28, 2026
Merged

Fix ASAN/UBSAN issues #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
468878c
Added libusb_unref_device when opening usb link
aljazdu Jan 13, 2026
0958262
Fixed overflowing inside of COMBINE_IDS macro
aljazdu Jan 12, 2026
c3c3851
Update include/XLink/XLinkPrivateFields.h
aljazdu Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/XLink/XLinkPrivateFields.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#define EXTRACT_STREAM_ID(streamId) ((streamId) & STREAM_ID_MASK)

#define COMBINE_IDS(streamId, linkid) \
streamId = streamId | ((linkid & LINK_ID_MASK) << LINK_ID_SHIFT);
streamId = streamId | (((uint32_t)linkid & LINK_ID_MASK) << LINK_ID_SHIFT);

// ------------------------------------
// Global fields declaration. Begin.
Expand Down
1 change: 1 addition & 0 deletions src/pc/protocols/usb_host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,7 @@ xLinkPlatformErrorCode_t usbLinkOpen(const char *path, libusb_device_handle*& h)

uint8_t ep = 0;
libusb_error libusb_rc = usb_open_device(dev, &ep, h);
libusb_unref_device(dev);
if(libusb_rc == LIBUSB_SUCCESS) {
return X_LINK_PLATFORM_SUCCESS;
} else if(libusb_rc == LIBUSB_ERROR_ACCESS) {
Expand Down
Loading