fix: COINGECKO_API_KEY optional — fall back to public CoinGecko#2
Open
zatsch wants to merge 1 commit into
Open
fix: COINGECKO_API_KEY optional — fall back to public CoinGecko#2zatsch wants to merge 1 commit into
zatsch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pricing service refused to start without
COINGECKO_API_KEYset, and even with an empty key it sent the literalx-cg-demo-api-key:header which CoinGecko rejects with401 — API Key Missing.This change makes the key optional — when unset, the binary boots, logs a notice, and the upstream HTTP requests omit the auth header so CoinGecko's bare public API responds (with the public/anonymous rate limit). Suitable for dev/staging deployments where pulling a real key into the cluster isn't worth it.
Test plan
COINGECKO_API_KEYunset → nolog.Fatal.GET /simple/price?ids=bitcoin&vs_currencies=usdreturns real prices via public CoinGecko.COINGECKO_API_KEYis set, behavior unchanged (header sent, demo URL used).