fix: add no-module to openssl static build#302
Merged
SinisterRectus merged 2 commits intoluvit:masterfrom Mar 3, 2025
Merged
Conversation
d461c80 to
b68b7f0
Compare
Ever since the update to openssl 3.x we have been building static openssl
ever so slightly incorrect. Without the `no-module` configuration option
openssl still tries to provide some non-core modules (like the legacy provider)
as a shared library. However luvi has no way to bundle this, and so ever since
the update to openssl 3.x we have been unable to use any of the legacy ciphers
in luvi.
I used the following script to ensure the provided fix actually works for the
legacy provider:
```lua
local openssl = require 'openssl'
print(openssl.errors())
local ctx = openssl.cipher.get('blowfish') -- any cipher provided by legacy works here
print(ctx)
print(ctx:cipher('123', '456', '789'))
```
Before this fix:
```
C06BE223E67B0000:error:12800067:DSO support routines:dlfcn_load:could not load the shared library:crypto/dso/dso_dlfcn.c:118:filename(.../lib64/ossl-modules/legacy.so): .../lib64/ossl-modules/legacy.so: cannot open shared object file: No such file or directory
C06BE223E67B0000:error:12800067:DSO support routines:DSO_load:could not load the shared library:crypto/dso/dso_lib.c:147:
C06BE223E67B0000:error:07880025:common libcrypto routines:provider_init:reason(37):crypto/provider_core.c:950:name=legacy
openssl.evp_cipher: 0x7be623dd52d8
nil unsupported 50856204
```
After this fix:
```
openssl.evp_cipher: 0x7fca1a4d8a98
�r���H�
```
Alongside fixing the static build of openssl, this also fixes the intermittent
issue with lua-openssl triggering the incompatible pointer types error by
silencing the warning, which lua-openssl does internally but only for clang.
b68b7f0 to
85d7d7b
Compare
squeek502
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since the update to openssl 3.x we have been building static openssl ever so slightly incorrect. Without the
no-moduleconfiguration option openssl still tries to provide some non-core modules (like the legacy provider) as a shared library. However luvi has no way to bundle this, and so ever since the update to openssl 3.x we have been unable to use any of the legacy ciphers in luvi.This was only observable by checking the list of openssl errors, because lua-openssl attempts to load both the default and legacy providers without handling any errors.
I used the following script to ensure the provided fix actually works for the legacy provider:
Before this fix:
After this fix:
Alongside fixing the static build of openssl, this also fixes the intermittent issue with lua-openssl triggering the incompatible pointer types error by silencing the warning for lua-openssl, which it does internally but only for clang.