pull request for port luvi to Lua 5.3#141
Conversation
|
Oops, it seems that I can not checkout a pull request branch that not merged :( stupid mistable :( |
|
Looks good, just fix the submodules. |
|
@creationix so the missing submodule is luvit/openssl, I submit a pull request to avoid amount of warnings building on VS2015. |
|
I have submit pull request to openssl but it seems not reply, I will try remove openssl update (only for avoid warnings) and commit again :) |
9620313 to
bdd11cd
Compare
bdd11cd to
d462a6c
Compare
|
lua-openssl need PTHREADS to enable |
pull request for port luvi to Lua 5.3
|
How can I build luvi using lua? I see the |
|
If I add |
|
? i use this option, let me check it |
|
I have double checked, using: build success, but I only checked on Windows, I will check on Linux. |
|
@creationix Sorry for my fall. I found a bug when build with Lua in luv, the default option to build Lua is build a amalg version (lua_one.c), but the path of file lua_one.c is wrong. I have made a pull request on up stream. but I tested: it works. After merge from up stream, simply define WITH_LUA_ENGINE works. I will make a CI pull request in time, and I think luv project need CI for plain Lua, too. |
|
Now that luvi can have multiple lua engines, we should show the engine and version in |
this is the first version for early review, to fix #140.
second commit resolved most warnings I meet when build on windows using VS2015.
To make this, I can check modifies on other platform (I only tested on Windows)