Skip to content

coro-http: Add TLS support, do not send header when header is missing#362

Closed
nilFinx wants to merge 0 commit intoluvit:masterfrom
nilFinx:coro-http/tls+no_empty_header_send
Closed

coro-http: Add TLS support, do not send header when header is missing#362
nilFinx wants to merge 0 commit intoluvit:masterfrom
nilFinx:coro-http/tls+no_empty_header_send

Conversation

@nilFinx
Copy link
Contributor

@nilFinx nilFinx commented Mar 6, 2026

Latter is another "me" thing, where some servers might not want to send anything after the request has been processed.

@Bilal2453
Copy link
Contributor

#310 already does this, it is blocked by #341.

For the header thing, I don't think that's quite right, this will leak the connection. A response is required per spec, you can't just ignore it. If you really want, respond with an empty write manually which will force close it.

@nilFinx nilFinx force-pushed the coro-http/tls+no_empty_header_send branch from a8d2886 to 990be6e Compare March 6, 2026 11:23
@nilFinx nilFinx closed this Mar 6, 2026
@nilFinx nilFinx force-pushed the coro-http/tls+no_empty_header_send branch from 990be6e to ba0dec5 Compare March 6, 2026 11:24
@nilFinx
Copy link
Contributor Author

nilFinx commented Mar 6, 2026

Unfortunately, I can't force close the connection - as that will, well, close the connection. I also can't return anything, as the client expects to see exactly HTTP/1.1 200 Connection Established\r\n\r\n before other operation in a loop happens, which does the TLS handshake.

And... oops. The PR is closed by pure accident. I'll reopen it, if you're fine with still getting it upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants