Open
Conversation
* improve error reporting * improve user facing feedback (such as where to find the binaries) * improve reliability (retry fetching from lit.luvit.io) * allow selecting a luvit version to install * fix for luvit 2.15+ new download url work: cleanup work: add get-lit.ps1 work: clean up download
fix: properly fetch latest luvi fix: version comparison is not ignoring prefixed v fix: not exiting on lit failure fix: improper arch detection compatibility with older PS versions refactor: use Invoke-WebRequest instead of legacy WebClient refactor: clean the powershell script refactor: use [version] for PS version comparisons feat: allow version env variables starting with v feat: add check for the minimum luvi requirement for lit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhauls the get-lit scripts to support new luvi versioning, and other QoL improvements.
Changes overview
latest.3.9.0from3.8.5.Notes
--retrysupport.WebClientPowerShell API in favour ofInvoke-WebRequest.Possible to-dos
lit makeoutput into a log file, which is only cleaned on successful runs.latestas a default version for luvi and lit.Tested most of the features I could on a Windows 10 machine (PS 5.1), PowerShell +7 on Linux and the sh script on Linux. I'm not exactly good at shell scripting, so hopefully this looks clean enough!
Most of this is @truemedian's work, many thanks to him!
Supersedes #353 and previous attempts.