Simulation Optimization#5
Open
kevinkarl03 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Removed the old sorted() call and instead using a sorted list that sorts in insert. This list is also pruned when current timestamp is ahead of the list's already planned activities. (Removes old planned activities)
Why this helps
This improves simulation time drastically scaling with activities per day (since we sort on every iteration on each day). This gives no major improvement on logs that have few cases / activities per day, but on logs where there is a lot of cases / activities simulation time is cut.
Examples of improvements
Below are some examples of simulation time on some logs, note the improvement on tst_cvs_pharmacy (since this has a lot of cases per day)
With simulation time it is meant ONLY simulation, not simulation + discovery