Merged
Conversation
Eli-Parker
force-pushed
the
fix-disappearing-beep-reason
branch
from
f56ea19 to
db69d5e
Compare
Owner
|
Nice catch with the FA calling the command. Could you just add " ... if Float Accessories is installed" to the Fix: trailer to make it a bit more specific? |
Eli-Parker
force-pushed
the
fix-disappearing-beep-reason
branch
from
db69d5e to
eb7d245
Compare
Contributor
Author
|
Should be all good! |
Fix: Stop the "last beep reason" text from disappearing once the beep condition stops for users running Float Accessories
Eli-Parker
force-pushed
the
fix-disappearing-beep-reason
branch
from
eb7d245 to
31a8ad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Stop the "last beep reason" text from disappearing once the beep condition stops
Got this fix finalized. I was also thinking the "sensor stop condition" and "last beep reason" texts should always be visible to let the users know that they're able to see that data if it's applicable.